Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to spec descriptions and examples #213

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Conversation

catkins-miso
Copy link
Contributor

@catkins-miso catkins-miso commented Nov 15, 2024

This mostly is just sharpening up the prose in the spec itself, but there was a bad example of RT proposal returning 422 Unprocessable when the proposal was incomplete, which is not the intended semantics of that POST.

@catkins-miso catkins-miso marked this pull request as ready for review November 15, 2024 16:34
@catkins-miso catkins-miso added this to the 1.0.0 milestone Nov 15, 2024
Copy link
Contributor

@getorymckeag getorymckeag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor reactions to language. Feel free to scoff at me, I'm just trying to be helpful. Overall, this is a positive improvement and nice cleanup.

docs/_spec/openapi-split.yaml Outdated Show resolved Hide resolved
docs/_spec/openapi-split.yaml Outdated Show resolved Hide resolved
catkins-miso and others added 2 commits November 15, 2024 13:04
Co-authored-by: Tory McKeag <143734462+getorymckeag@users.noreply.github.com>
Signed-off-by: Christopher Atkins <57670484+catkins-miso@users.noreply.github.com>
Co-authored-by: Tory McKeag <143734462+getorymckeag@users.noreply.github.com>
Signed-off-by: Christopher Atkins <57670484+catkins-miso@users.noreply.github.com>
@catkins-miso catkins-miso merged commit 6166f96 into 1.0.0-wip Nov 15, 2024
3 checks passed
@catkins-miso catkins-miso deleted the prose-improvements branch November 15, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants